Add Checks for temp path in Block Cache while mouting #1545
+40
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syeleti-msft
requested review from
vibhansa-msft,
souravgupta-msft,
ashruti-msft and
jainakanksha-msft
as code owners
vibhansa-msft
approved these changes
Oct 24, 2024
souravgupta-msft
approved these changes
Oct 29, 2024
Co-authored-by: Sourav Gupta <[email protected]>
ashruti-msft
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why - We are facing issues when tempPath is not Empty. Mount is successful even if tempPath is not empty in case of block Cache scenario. Ideally temp path sould be empty before proceeding ahead after unmount or over a clean start.
what - Check temppath is not same as mount path, Check temppath is empty to get the succeess from the mount