Generate default config #1535
Open
Generate default config #1535
+544
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-test-config command have to make it diff
ashruti-msft
requested review from
vibhansa-msft,
souravgupta-msft,
syeleti-msft and
jainakanksha-msft
as code owners
|
Thinking about our genConfig functionality should be treated as an independent feature. Much like how our mount and unmount commands operate as standalone functions, it makes sense for genConfig to independently generate and dump all default configurations into a file. This way, it won't rely on the existing implementation, ensuring a cleaner, more modular approach. Flow - So rather than just extending the current functionality make it an independent feature as describe in sequence diagram. |
|
also rename the command file to genConfig to align with product design. |
|
@jainakanksha-msft made the reqd changes according to your suggestions lmk if this looks good. |
vibhansa-msft
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have added flag to generate optimal config for direct io mode as well.
sample file cache config file generated: