Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Rename function logic to reduce the number of REST API calls. #1459

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Optimize Rename function logic to reduce the number of REST API calls. #1459

wants to merge 20 commits into from
+32 −23

Conversation

syeleti-msft
Copy link
Member

@syeleti-msft syeleti-msft commented Jul 15, 2024 •
edited
Loading

Rename on FNS:
API calls: There are 6 REST api calls assosiated with this operation.

  1. GetAttr(src)---------list call (filesystem call)
  2. GetAttr(dst)---------list call (filesystem call)
  3. GetBlobproperties call(src) ------------(rename function)
  4. copyblob(src->dst)----------(rename function)
  5. deleteblob(src)--------------(rename function)
  6. GetAttr(dst)---------list call (filesystem call)

3 is an extra call, removed it from the code

Rename on HNS:
API Calls: There are 4 REST api calls assosiated with this operation.

  1. GetBlobProperties on Dst
  2. GetBlobProperties on Source
  3. RenamePathFile
  4. GetBlobProperties on Dst

@vibhansa-msft vibhansa-msft added this to the V2-2.3.1 milestone Jul 17, 2024
@syeleti-msft syeleti-msft force-pushed the syeleti/rename-optimization branch 2 times, most recently from d777033 to 83c6a96 Compare July 25, 2024 18:27
@vibhansa-msft vibhansa-msft modified the milestones: V2-2.3.1, v2-2.3.2 Jul 26, 2024
@vibhansa-msft vibhansa-msft changed the base branch from main to feature/2.3.2 August 1, 2024 09:18
@ashruti-msft ashruti-msft removed this from the v2-2.3.2 milestone Aug 20, 2024
@ashruti-msft ashruti-msft added this to the v2-2.4.0 milestone Aug 20, 2024
Base automatically changed from feature/2.3.2 to main August 23, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jainakanksha-msft jainakanksha-msft jainakanksha-msft left review comments

@vibhansa-msft vibhansa-msft vibhansa-msft approved these changes

@ashruti-msft ashruti-msft ashruti-msft approved these changes

@souravgupta-msft souravgupta-msft Awaiting requested review from souravgupta-msft souravgupta-msft is a code owner

Assignees
No one assigned
Labels
performance ready-to-merge V2
Projects
None yet
Milestone
v2-2.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@syeleti-msft @vibhansa-msft @ashruti-msft @jainakanksha-msft @souravgupta-msft