Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct behavior when syncing with delete-destination-files #2818

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adreed-msft
Copy link
Member

The original code for delete-destination-files accidentally passed through all files when delete-destination-files was enabled.

This PR removes the accidental code and implements a test to validate that the override does not occur, further validating the two use cases this flag was intended to cover--

  1. A blob previously written to via the dfs endpoint
  2. A blob previously written to with another tool that uses different block ID lengths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant