Fix to the panic due to the send on a closed channel #2804
+30
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonwuakpa-msft
requested review from
gapra-msft,
adreed-msft,
dphulkar-msft,
vibhansa-msft,
seanmcc-msft,
souravgupta-msft and
tanyasethi-msft
as code owners
|
Just wondering if we could add a testcase around it. |
|
@dphulkar-msft This bug fix, to me, seems tricky to test because of its non-deterministic nature. I was able to repro the error the customer had without having a panic on my end. In some cases, it might panic, in others it might not. It boils down to the timing of closing a channel before sending a message down it. |
adreed-msft
approved these changes
Sep 17, 2024
vibhansa-msft
approved these changes
Sep 18, 2024
dphulkar-msft
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for GitHub issue #2703
Implemented a RWMutex to ensure exclusive access to critical parts of the codebase i.e channel closures and sends. The issue linked above is related specifically to the
xferDonechannel. Similar implementation was done for other channels injobStatusManagerwith the mutually exclusive read and write locks.