TraverserTests #2732
Open
TraverserTests #2732
+992
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mawhite-msft
requested review from
gapra-msft,
adreed-msft,
nakulkar-msft,
siminsavani-msft,
vibhansa-msft,
seanmcc-msft and
pranavmalik-msft
as code owners
gapra-msft
reviewed
Jul 15, 2024
| a.Nil(err) | ||
|
|
||
| //the mock server responds with a status code error | ||
| srv.AppendResponse(mock_server.WithStatusCode(403), mock_server.WithHeader("x-ms-error-code", "BlobNotFound"), mock_server.WithBody([]byte(MockErrorBody("BlobNotFound")))) |
There was a problem hiding this comment.
nit: BlobNotFound is usually a 404 in http world. If we want to use 403, we should take a look at common error codes for Blob and choose an appropriate one.
adreed-msft
approved these changes
Jul 16, 2024
| return nil | ||
| }, []ObjectFilter{}) | ||
| a.Equal(map[string]StoredObject{}, seenFiles) | ||
| a.Equal("this blob uses customer provided encryption keys (CPK). At the moment, AzCopy does not support CPK-encrypted blobs. If you wish to make use of this blob, we recommend using one of the Azure Storage SDKs", err.Error()) |
There was a problem hiding this comment.
This might be out of scope, but for these more specific errors, perhaps we should just have a zt_traverser_errors.go file where we store all of these strings in one place, that way, if it gets used in multiple places, or changed in the future, it's a zero-brainpower operation to find all the places to change it in tests and such.
mawhite-msft
requested review from
dphulkar-msft,
souravgupta-msft and
tanyasethi-msft
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests with mocked responses for zc_traverser_blob