Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleaned up logs #2602

Merged
merged 5 commits into from
Mar 15, 2024
Merged

cleaned up logs #2602

merged 5 commits into from
Mar 15, 2024

Conversation

anjalitambe
Copy link
Contributor

Occasionally, I need to extract logs using regex, but there is an inconvenience due to the inconsistency of string messages in the generated .log file. To address this issue, I've added changes in the show, sync, resume, and copy files, ensuring consistent casing and spacing for messages like these:

TotalBytesTransferred ---> Total Number of Bytes Transferred
Total Number Of Copy Transfers ---> Total Number of Copy Transfers

@anjalitambe
Copy link
Contributor Author

@microsoft-github-policy-service agree

@anjalitambe
Copy link
Contributor Author

@anjalitambe please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

Copy link
Member

@adreed-msft adreed-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things:

  1. I'd like to suggest you take a look at the json output and see if it fits your needs better than regex'ing the human-readable output. --output-type=json, I believe is documented in the root command. If not, we'd really love to hear your feedback on what makes the json output hard to use.
  2. Technically this could break other people in the same process, but imo, automation customers should be using computer-readable output schemes anyway.

Overall, this is a good set of changes-- human readable schemes shouldn't be taking on field names directly, anyway.

@gapra-msft gapra-msft merged commit d6d5c76 into Azure:main Mar 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants