-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Minimise mumber of calls to folder create in case of Blob to File Copy #2591
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any way to test this?
@@ -674,6 +674,12 @@ func NewFolderPropertyOption(fromTo common.FromTo, recursive, stripTopDir bool, | |||
} | |||
} | |||
|
|||
// In case of a Blob to File Copy, we will go for all folder copy | |||
if fromTo == common.EFromTo.BlobFile() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we decided to use the mitigation (customer sets include directory flag) and get to this issue in a later release after we have a solid plan?
@seanmcc-msft @vibhansa-msft thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can consider this fix for the next release (not for 10.23). Once we have more clarity on the flow, may be we can improvise the fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to consider the part where putting such check may take away the capabilities to skip empty folders while copying.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is neither a proper fix to the issue (If the source has no directory stubs, the issue resurfaces), nor is it what was discussed (temp mitigation by manual flag setting, spike for next release)
Description:
This pull request addresses a regression stemming from the existing logic for Blob to File Copy. Previously, the default case returned a nullFolderTracker, lacking the mechanism to track already created folders. Considering this a corner case, the proposed solution introduces the AllFolderCopy approach. With this enhancement, the foldertracker logic now effectively monitors previously created folders, thereby reducing redundant folder creation during Blob to File operations.
Changes: