PS and CLI creds #2433
PS and CLI creds #2433
Conversation
nakulkar-msft
requested review from
gapra-msft,
adreed-msft,
siminsavani-msft,
vibhansa-msft and
tasherif-msft
as code owners
nakulkar-msft
force-pushed
the
nakulkar/private/psCLICreds
branch
from
720fb69
to
01a7b8b
Compare
| @@ -114,6 +114,17 @@ func GetOAuthTokenManagerInstance() (*common.UserOAuthTokenManager, error) { | |||
|
|
|||
| case "DEVICE": | |||
| lca.identity = false | |||
|
|
|||
| case "AZCLI": | |||
| lca.identity = false | |||
There was a problem hiding this comment.
in the future we might be able to improve this by creating an enum for oauth cred type instead of having a bunch of booleans
| return output, nil | ||
| } | ||
|
|
||
| func (c *PowershellContextCredential) createAccessToken(tk []byte) (azcore.AccessToken, error) { |
There was a problem hiding this comment.
can we add UT for some of these methods?
There was a problem hiding this comment.
Did you add tests for some of these methods?
There was a problem hiding this comment.
The test covers entire workflow.
There was a problem hiding this comment.
Which test? I only see some changes to runner, how does that get picked up in CI?
There was a problem hiding this comment.
KMN. Thanks for getting this. I had not checked in the file. I've checked in now, need to get some environment vars correct in CI.
There was a problem hiding this comment.
great! thanks for double checking that. I thought I was going crazy for a minute
…nto nakulkar/private/psCLICreds2
| @@ -32,7 +32,7 @@ import ( | |||
| var loginCmdArg = loginCmdArgs{tenantID: common.DefaultTenantID} | |||
|
|
|||
| var loginNotice = "'azcopy %s' command will be deprecated starting release 10.22. " + | |||
There was a problem hiding this comment.
You could probably update this to 10.23 since we are skipping this release, right?
There was a problem hiding this comment.
I'll add that as a different review. Deviates from topic.
No description provided.