Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade linting version #2105

Merged
merged 3 commits into from
Mar 8, 2023
Merged

Upgrade linting version #2105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
311bf78
Upgrade linting
gapra-msft Mar 8, 2023
5c3b688
fix spelling in testsuite
gapra-msft Mar 8, 2023
a2323a4
remove redundant if
gapra-msft Mar 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/golangci-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,20 +16,20 @@ jobs:
golangci:
strategy:
matrix:
go: [1.17]
go: [1.18]
os: [ubuntu-latest, windows-latest, macos-latest]
name: lint
runs-on: ${{ matrix.os }}
steps:
- uses: actions/setup-go@v3
with:
go-version: ${{ matrix.go }}
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: golangci-lint
uses: golangci/golangci-lint-action@v2
uses: golangci/golangci-lint-action@v3
with:
# Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
version: v1.46
version: latest
# Optional: working directory, useful for monorepos
# working-directory: somedir

Expand Down
5 changes: 0 additions & 5 deletions cmd/copyEnumeratorInit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,11 +614,6 @@ func (cca *CookedCopyCmdArgs) MakeEscapedRelativePath(source bool, dstIsDir bool
return pathEncodeRules(relativePath, cca.FromTo, cca.disableAutoDecoding, source)
}

// user is not placing the source as a subdir
if object.isSourceRootFolder() && !asSubdir {
relativePath = ""
}

// If it's out here, the object is contained in a folder, or was found via a wildcard, or object.isSourceRootFolder == true
if object.isSourceRootFolder() {
relativePath = "" // otherwise we get "/" from the line below, and that breaks some clients, e.g. blobFS
Expand Down
2 changes: 1 addition & 1 deletion testSuite/scripts/utility.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ def execute_azcopy_info(self):
def execute_testsuite_upload(self):
return verify_operation(self.string())

# processes oauth command according to swtiches
# processes oauth command according to switches
def process_oauth_command(
cmd,
fromTo=""):
Expand Down