Fixed a bug where preserve permissions would not work with OAuth #1963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gapra-msft
requested review from
adreed-msft,
nakulkar-msft,
tasherif-msft and
siminsavani-msft
| jpm.secondarySourceProviderPipeline = NewBlobFSPipeline( | ||
| azbfs.NewAnonymousCredential(), | ||
| credential, |
There was a problem hiding this comment.
Is this something that hits only in creating secondarySource. As function is createPipeline sounds like having a wrong credential here should have never worked so just want to understand what condition is failing here.
There was a problem hiding this comment.
this works when using SAS since anonymous credential is for SAS. But if customer uses OAuth we never set that credential (it was anonymous cred)_so we failed for all datalake endpoint operations w/ OAuth
vibhansa-msft
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.