-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Job Manager changes #1820
Job Manager changes #1820
Conversation
JobMgr Cleanup. - Close all the go routines once job is done. Fix for Report Handler routine cleanup. Remove ChangeLogLevel change. Memory Leak Fix. - Set the nil to address allocated memory. - Fixing some of memory issues. - JobMgr is freed without setting channel to nil.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace fmt.Print with appropriate log statements
@nitin-deamon @mohsha-msft |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much appreciated changes! ❤️
LGTM.
Please add all TODOs from your PR in a backlog so we can track them for future releases.
NOTE - This PR is a subset of the following PR: #1797
JobMgr Cleanup. (Cherry-picked from personal/nitin/xdatamove)
Fix for Report Handler routine cleanup. (Cherry-picked from personal/nitin/xdatamove)
Memory Leak Fix. (Cherry-picked from personal/nitin/xdatamove)
Set the nil to address allocated memory.
Fixing some of memory issues.
JobMgr is freed without setting channel to nil.