Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug#1630 Empty subfolders created when using --recursive and -preserve-permissions #1671

Merged
merged 5 commits into from
Feb 22, 2022

Conversation

tiverma-msft
Copy link
Collaborator

@tiverma-msft tiverma-msft commented Feb 14, 2022

I checked if the size of the object is not 0, because all the folders have a size of 0.

@mohsha-msft
Copy link
Contributor

A file can be of 0B too, right? Will your fix work in that case?

@tiverma-msft
Copy link
Collaborator Author

A file can be of 0B too, right? Will your fix work in that case?
Oh yes, in fact this was my only concern with respect to this fix.
Basically the idea is, if we can pinpoint which traversed objects are files and which are folders, we can selectively add rootdir to the files and the code will work (according to me) fine.
I tried to run the code this way and it ran without the issue arising.

@ghost
Copy link

ghost commented Feb 15, 2022

CLA assistant check
All CLA requirements met.

@zezha-msft zezha-msft merged commit 038ca7b into Azure:dev Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra empty sub folders created when using --recursive and --preserve-permissions
5 participants