Conversation
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull request overview
This PR syncs the eng/common directory with azure-sdk-tools PR #14400, introducing a configurable allow-list mechanism for relative links in the link verification script. Previously, relative links were only special-cased for files matching instructions.md$; now a pattern file (allow-relative-links.txt) drives which files are permitted to use relative links.
Changes:
- Added
allow-relative-links.txtwith glob patterns (.github/**,eng/**) for files that may use relative links. - Updated
Verify-Links.ps1to load patterns from the allow-list file, match page URIs against them, and skip the relative-link warning for matching pages while still verifying link correctness. - Updated the pipeline template to pass the new
allowRelativeLinksFileparameter to the script.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| eng/common/scripts/allow-relative-links.txt | New file defining glob patterns for pages allowed to use relative links. |
| eng/common/scripts/Verify-Links.ps1 | Adds the allowRelativeLinksFile parameter, pattern-loading logic, a matching function, and integrates the per-page flag into link resolution and checking. |
| eng/common/pipelines/templates/steps/verify-links.yml | Adds AllowRelativeLinksFile pipeline parameter and passes it to the script invocation. |
weshaggard
approved these changes
Mar 10, 2026
…sFile parameter Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>
…idance checks active Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>
…-links.txt Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>
…ll repos Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…, remove eng/** Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>
Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>
azure-sdk
force-pushed
the
sync-eng/common-copilot/allow-relative-path-links-again-14400
branch
from
3b679d8 to
e08e216
Compare
weshaggard
approved these changes
Mar 10, 2026
azure-sdk
deleted the
sync-eng/common-copilot/allow-relative-path-links-again-14400
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#14400 See eng/common workflow