Sync eng/common directory with azure-sdk-tools for PR 14196#9671
Merged
Sync eng/common directory with azure-sdk-tools for PR 14196#9671
Conversation
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull request overview
This PR syncs the eng/common directory with azure-sdk-tools repository PR #14196. The changes add support for removing Storage Sync Services that can block resource group deletion, update subscription references to point to a new test subscription, and add warning suppression to subscription selection calls.
Changes:
- Added new
Remove-StorageSyncServicesfunction to handle cleanup of Storage Sync Services and their dependencies (sync groups, cloud endpoints, server endpoints) - Updated default test subscription from "Azure SDK Developer Playground" to "Azure SDK Test Resources - TME" with new subscription ID
- Added
-WarningAction Ignoreto subscription selection calls to suppress warnings
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/common/scripts/Helpers/Resource-Helpers.ps1 | Adds new Remove-StorageSyncServices function with hierarchical cleanup of sync services, groups, and endpoints |
| eng/common/TestResources/Update-TestResources.ps1 | Updates subscription references, adds warning suppression, contains bug in exit action (line 96) |
| eng/common/TestResources/Remove-TestResources.ps1 | Adds module requirements for Az.Storage and Az.StorageSync, updates subscription references, adds call to new cleanup function |
benbp
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#14196 See eng/common workflow