Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR syncs the eng/common directory with azure-sdk-tools for PR 13202, adding artifact filtering capabilities to the package properties processing pipeline. The changes enable selective processing of packages based on a provided artifact list, which is particularly useful for daily dev builds where only specific artifacts need to be processed.
- Added artifact filtering functionality to
Save-Package-Properties.ps1with comprehensive validation and error handling - Integrated the new artifact filtering parameter into the daily dev build pipeline template
- Fixed a documentation typo ("Verison" → "Version")
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| eng/common/scripts/Save-Package-Properties.ps1 | Added artifactList parameter with filtering logic, including null/whitespace validation, case-insensitive matching using HashSet, and warning messages for packages missing ArtifactName property. Fixed spelling in documentation. |
| eng/common/pipelines/templates/steps/daily-dev-build-variable.yml | Added Artifacts parameter and passed it to Save-Package-Properties.ps1 as artifactList, extracting artifact names from the JSON array using PowerShell expression. |
raych1
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13202 See eng/common workflow