Skip to content

Sync eng/common directory with azure-sdk-tools for PR 12562#9312

Merged
helen229 merged 1 commit intomainfrom
sync-eng/common-gaoh/script-new-12562
Oct 20, 2025
Merged

Sync eng/common directory with azure-sdk-tools for PR 12562#9312
helen229 merged 1 commit intomainfrom
sync-eng/common-gaoh/script-new-12562

Conversation

@azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12562 See eng/common workflow

Copilot AI review requested due to automatic review settings October 20, 2025 17:59
@azure-sdk azure-sdk requested a review from a team as a code owner October 20, 2025 17:59
@azure-sdk azure-sdk requested a review from helen229 October 20, 2025 17:59
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Oct 20, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR syncs the eng/common directory with azure-sdk-tools to add package type information to API review submissions. The changes enable passing the SDK type (e.g., client, management) from package metadata through to the APIView service.

Key changes:

  • Add packageType parameter to API review submission functions
  • Extract packageType from packageInfo.SdkType in processing logic
  • Include packageType in both query parameters and multipart form data for different upload methods

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
eng/common/scripts/Detect-Api-Changes.ps1 Adds packageType parameter extraction and passes it to Submit-Request function
eng/common/scripts/Create-APIReview.ps1 Adds packageType parameter to upload functions and includes it in API requests

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@helen229 helen229 merged commit 8361b53 into main Oct 20, 2025
8 checks passed
@helen229 helen229 deleted the sync-eng/common-gaoh/script-new-12562 branch October 20, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants