Sync eng/common directory with azure-sdk-tools for PR 11353#9040
Merged
Sync eng/common directory with azure-sdk-tools for PR 11353#9040
Conversation
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR synchronizes the eng/common directory with azure-sdk-tools repository changes from PR 11353, focusing on improvements to PowerShell scripts for tool installation and path management.
- Improves PowerShell script reliability by ensuring proper directory creation and newline handling
- Fixes shebang line format for better cross-platform compatibility
- Enhances variable naming consistency in tool installation logic
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/common/scripts/Helpers/AzSdkTool-Helpers.ps1 | Adds newline before PATH command in shell profile to prevent formatting issues |
| eng/common/mcp/azure-sdk-mcp.ps1 | Fixes shebang, adds directory creation check, and improves variable naming consistency |
Comments suppressed due to low confidence (1)
eng/common/mcp/azure-sdk-mcp.ps1:68
- [nitpick] The variable name
$exeDestinationis inconsistent with the existing$exevariable that was being used for the same purpose. Consider using a more descriptive name like$installedExePathor keeping the original$exename for consistency.
$exeDestination = Join-Path $toolInstallDirectory $exeName
benbp
approved these changes
Jul 25, 2025
azure-sdk
deleted the
sync-eng/common-benbp/copilot-install-mac-fixes-11353
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#11353 See eng/common workflow