Skip to content

Sync eng/common directory with azure-sdk-tools for PR 10657 #8853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scbedd merged 2 commits into from
May 16, 2025
Merged

Sync eng/common directory with azure-sdk-tools for PR 10657 #8853

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d2c510
ensure the directory that gets logged is the actual changed packages …
scbedd May 15, 2025
a17c980
somehow messed up copy/pasta
scbedd May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions eng/common/pipelines/templates/steps/save-package-properties.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,26 @@ steps:
pwsh: true
workingDirectory: '${{ parameters.WorkingDirectory }}'

- task: Powershell@2
displayName: Save package properties filtered for PR
inputs:
filePath: ${{ parameters.ScriptDirectory }}/Save-Package-Properties.ps1
arguments: >
-PrDiff '${{ parameters.DiffDirectory }}/diff.json'
-OutDirectory '${{ parameters.PackageInfoDirectory }}'
pwsh: true
workingDirectory: '${{ parameters.WorkingDirectory }}'

# When running in PR mode, we want the detected changed services to be attached to the build as tags.
# However, the public identity does not have the permissions to attach tags to the build.
# Instead, we will save the changed services to a file, attach it as an attachment for PiplineWitness to pick up and utilize.
#
- pwsh: |
$changedServices = (Get-Content -Path '${{ parameters.DiffDirectory }}/diff.json' -Raw | ConvertFrom-Json).ChangedServices
$changedPackages = Get-ChildItem -Recurse -Filter *.json "${{ parameters.PackageInfoDirectory }}" `
| ForEach-Object { Get-Content -Raw $_ | ConvertFrom-Json }

$changedServices = $changedPackages | Where-Object { $_.IncludedForValidation -eq $false } `
| Select-Object -ExpandProperty ServiceDirectory | Sort-Object -Unique

if ($changedServices) {
Write-Host "Attaching changed service names to the build for additional tag generation."
Expand All @@ -55,15 +70,6 @@ steps:
displayName: Upload tags.json with changed services
workingDirectory: '${{ parameters.WorkingDirectory }}'

- task: Powershell@2
displayName: Save package properties filtered for PR
inputs:
filePath: ${{ parameters.ScriptDirectory }}/Save-Package-Properties.ps1
arguments: >
-PrDiff '${{ parameters.DiffDirectory }}/diff.json'
-OutDirectory '${{ parameters.PackageInfoDirectory }}'
pwsh: true
workingDirectory: '${{ parameters.WorkingDirectory }}'
- ${{ else }}:
- task: Powershell@2
displayName: Save package properties
Expand Down