Skip to content

Conversation

@jsquire
Copy link
Member

@jsquire jsquire commented Mar 9, 2021

Summary

The focus of these changes is to add information for the Event Hubs packages that were released for the March milestone.

Last Upstream Rebase

Tuesday, March 9, 1:15pm (EST)

@jsquire
Copy link
Member Author

jsquire commented Mar 9, 2021

@weshaggard: The broken link from analyze appears to be coming from the JS packages CSV that was introduced with #2497 after which the package got flagged by NPM for security reasons and de-listed. This file seems to be part of an automated feed. Do you have any guidance on how I would go about updating it?

A big, big thanks to @chradek for solving the mystery of the root cause.

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets try to use #2502 for collecting these.

@jsquire
Copy link
Member Author

jsquire commented Mar 9, 2021

Lets try to use #2502 for collecting these.

The script still requires manual clean-up for the text of each service to adapt the verbose changelog to the release notes. I'm fine deferring to @Mohit-Chakraborty release manager for a central run and rescoping this PR to fix the text after.

@weshaggard
Copy link
Member

If there are any manual clean-up feel free to update the PR with those changes. The entire goal is to try and see what, if any, those changes are so we can start to tweak and improve the process.

@jsquire
Copy link
Member Author

jsquire commented Mar 10, 2021

If there are any manual clean-up feel free to update the PR with those changes. The entire goal is to try and see what, if any, those changes are so we can start to tweak and improve the process.

Understood. I was just noting that I don't want to step on the release manager's toes and pull the script run into this PR. Once that's run, I'll rescope this to do the updates or fold these changes in. I'm leaving this open in the meantime to remind me.

The focus of these changes is to add information for the Event Hubs
packages that were released for the March milestone.
@jsquire jsquire force-pushed the eventhubs/march-release branch from 206c86c to 3d90fe9 Compare March 10, 2021 13:16
@weshaggard
Copy link
Member

It looks like our automation already pulled in the eventhubs changes in to #2502 so please have a look over it and if it matches what you want great there is nothing to do. If it needs some tweaks you can go ahead and push a commit to that PR with those tweaks.

@jsquire
Copy link
Member Author

jsquire commented Mar 10, 2021

It looks like our automation already pulled in the eventhubs changes in to #2502 so please have a look over it and if it matches what you want great there is nothing to do. If it needs some tweaks you can go ahead and push a commit to that PR with those tweaks.

oh! my bad. I'm guilty of assuming the PR that you linked was the script; I didn't click through to see you were sharing generated doc. Thanks, @weshaggard, and apologies for the confusion.

@jsquire
Copy link
Member Author

jsquire commented Mar 10, 2021

Closing this out; changes have been suggested on #2502.

@jsquire jsquire closed this Mar 10, 2021
@jsquire jsquire deleted the eventhubs/march-release branch March 10, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants