-
Notifications
You must be signed in to change notification settings - Fork 350
[March Release] Adding Event Hubs Info #2524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@weshaggard: The broken link from analyze appears to be coming from the JS packages CSV that was introduced with #2497 after which the package got flagged by NPM for security reasons and de-listed. This file seems to be part of an automated feed. Do you have any guidance on how I would go about updating it? A big, big thanks to @chradek for solving the mystery of the root cause. |
weshaggard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets try to use #2502 for collecting these.
The script still requires manual clean-up for the text of each service to adapt the verbose changelog to the release notes. I'm fine deferring to @Mohit-Chakraborty release manager for a central run and rescoping this PR to fix the text after. |
|
If there are any manual clean-up feel free to update the PR with those changes. The entire goal is to try and see what, if any, those changes are so we can start to tweak and improve the process. |
Understood. I was just noting that I don't want to step on the release manager's toes and pull the script run into this PR. Once that's run, I'll rescope this to do the updates or fold these changes in. I'm leaving this open in the meantime to remind me. |
The focus of these changes is to add information for the Event Hubs packages that were released for the March milestone.
206c86c to
3d90fe9
Compare
|
It looks like our automation already pulled in the eventhubs changes in to #2502 so please have a look over it and if it matches what you want great there is nothing to do. If it needs some tweaks you can go ahead and push a commit to that PR with those tweaks. |
oh! my bad. I'm guilty of assuming the PR that you linked was the script; I didn't click through to see you were sharing generated doc. Thanks, @weshaggard, and apologies for the confusion. |
|
Closing this out; changes have been suggested on #2502. |
Summary
The focus of these changes is to add information for the Event Hubs packages that were released for the March milestone.
Last Upstream Rebase
Tuesday, March 9, 1:15pm (EST)