Skip to content

Sync eng/common directory with azure-sdk-tools for PR 16674 - #10223

Merged
Ben Broderick Phillips (benbp) merged 2 commits into
mainfrom
sync-eng-common-weikanglim/pr-job-batch-size-by-pool-16674
Aug 12, 2026
Merged

Sync eng/common directory with azure-sdk-tools for PR 16674#10223
Ben Broderick Phillips (benbp) merged 2 commits into
mainfrom
sync-eng-common-weikanglim/pr-job-batch-size-by-pool-16674

Conversation

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#16674 See eng/common workflow

@azure-sdk-automation
azure-sdk-automation Bot requested a review from a team as a code owner August 11, 2026 18:05
@azure-sdk-automation
azure-sdk-automation Bot requested review from Wei Lim (weikanglim) and a balanced review from Copilot August 11, 2026 18:05
@azure-sdk-automation azure-sdk-automation Bot added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Aug 11, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.

Adds support for pool-specific PR batch-size overrides when generating the PR job matrix, while keeping the existing default batch size behavior.

Changes:

  • Introduces a new PRJobBatchSizeByPool parameter for per-pool batch-size overrides.
  • Adds PowerShell logic to select and validate an override (including handling unset runtime macros).
  • Passes the computed $batchSize into Create-PrJobMatrix.ps1 instead of the static parameter value.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread eng/common/pipelines/templates/jobs/generate-job-matrix.yml
Comment thread eng/common/pipelines/templates/jobs/generate-job-matrix.yml

@weikanglim Wei Lim (weikanglim) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The synchronized eng/common change is ready. The required Verify Site failure is unrelated to this one-file template sync and is caused by pre-existing stale Time Series Insights links in the generated 2021-05 release page; all review threads are resolved.

Wei Lim (weikanglim) and others added 2 commits August 12, 2026 20:35
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@azure-sdk-automation
azure-sdk-automation Bot force-pushed the sync-eng-common-weikanglim/pr-job-batch-size-by-pool-16674 branch from d1ff53d to 0826b56 Compare August 12, 2026 20:35
@weikanglim

Copy link
Copy Markdown
Member

/check-enforcer override

@benbp
Ben Broderick Phillips (benbp) merged commit 5db7b1c into main Aug 12, 2026
3 of 4 checks passed
@benbp
Ben Broderick Phillips (benbp) deleted the sync-eng-common-weikanglim/pr-job-batch-size-by-pool-16674 branch August 12, 2026 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants