Skip to content

Support spec PR scenario in sdk gen pipeline template #9670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2025
Merged

Support spec PR scenario in sdk gen pipeline template #9670

merged 1 commit into from
Jan 24, 2025

Conversation

@raych1
Copy link
Member

@raych1 raych1 commented Jan 21, 2025 •
edited
Loading

  • use 'azure-sdk' forked repo for spec PR scenario
  • use spec PR info for checkout and spec-gen-sdk

@raych1 raych1 requested a review from a team as a code owner January 21, 2025 21:18
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 21, 2025

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@raych1 raych1 linked an issue Jan 21, 2025 that may be closed by this pull request
Support spec PR trigger in base pipeline template #9631
Closed
maririos
maririos approved these changes Jan 22, 2025
View reviewed changes
weshaggard
weshaggard reviewed Jan 22, 2025
View reviewed changes
weshaggard
weshaggard reviewed Jan 23, 2025
View reviewed changes
weshaggard
weshaggard reviewed Jan 23, 2025
View reviewed changes
weshaggard
weshaggard reviewed Jan 23, 2025
View reviewed changes
@raych1 raych1 force-pushed the user/raych1/support-spec-pr branch from ae405cd to a5e1edc Compare January 23, 2025 23:54
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 24, 2025

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Jan 24, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Jan 24, 2025
@azure-sdk @raych1
Sync eng/common directory with azure-sdk-tools for PR 9670 (#32696)
0b0c82e 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#9670 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

Co-authored-by: ray chen <[email protected]>
@raych1 raych1 merged commit e811bea into main Jan 24, 2025
8 checks passed
@raych1 raych1 deleted the user/raych1/support-spec-pr branch January 24, 2025 00:48
@maorleger maorleger mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weshaggard weshaggard weshaggard approved these changes

@maririos maririos maririos approved these changes

@chidozieononiwu chidozieononiwu Awaiting requested review from chidozieononiwu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support spec PR trigger in base pipeline template

5 participants

@raych1 @azure-sdk @weshaggard @maririos