Codeline Search #9605
Merged
Codeline Search #9605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Copilot reviewed 5 out of 14 changed files in this pull request and generated 1 comment.
Files not reviewed (9)
- src/dotnet/APIView/APIViewWeb/Client/css/shared/theme-colors.scss: Language not supported
- src/dotnet/APIView/ClientSPA/src/app/_components/code-panel/code-panel.component.html: Language not supported
- src/dotnet/APIView/ClientSPA/src/app/_components/code-panel/code-panel.component.scss: Language not supported
- src/dotnet/APIView/ClientSPA/src/app/_components/review-page-options/review-page-options.component.html: Language not supported
- src/dotnet/APIView/ClientSPA/src/app/_components/review-page-options/review-page-options.component.scss: Language not supported
- src/dotnet/APIView/ClientSPA/src/app/_components/review-page/review-page.component.html: Language not supported
- src/dotnet/APIView/ClientSPA/src/ng-prime-overrides.scss: Language not supported
- src/dotnet/APIView/ClientSPA/src/app/_modules/shared/review-page-layout.module.ts: Evaluated as low risk
- src/dotnet/APIView/ClientSPA/src/app/_modules/shared/shared-app.module.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)
src/dotnet/APIView/ClientSPA/src/app/_models/codeLineSearchInfo.ts:4
- [nitpick] The property name
matchedNodeIdscould be more descriptive. Consider renaming it tomatchedNodeIdSetto clearly indicate it is a Set.
matchedNodeIds: Set<string>
src/dotnet/APIView/ClientSPA/src/app/_components/review-page/review-page.component.ts
Outdated
Show resolved
Hide resolved
maririos
reviewed
Jan 8, 2025
Member
maririos
left a comment
maririos
left a comment
There was a problem hiding this comment.
Could you add a video of how it works and tests for the search section?
src/dotnet/APIView/ClientSPA/src/app/_components/code-panel/code-panel.component.ts
Show resolved
Hide resolved
src/dotnet/APIView/ClientSPA/src/app/_components/code-panel/code-panel.component.ts
Show resolved
Hide resolved
src/dotnet/APIView/ClientSPA/src/app/_components/code-panel/code-panel.component.ts
Outdated
Show resolved
Hide resolved
chidozieononiwu
force-pushed
the
accesibility/ReviewSearch
branch
from
01b6637 to
f667188
Compare
chidozieononiwu
force-pushed
the
accesibility/ReviewSearch
branch
from
f667188 to
7369fde
Compare
chidozieononiwu
force-pushed
the
accesibility/ReviewSearch
branch
from
7369fde to
a2bf3bb
Compare
praveenkuttappan
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.