Skip to content

Upgrade the revisions on the fly #9171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Upgrade the revisions on the fly #9171

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef5e4ec
Upgrade the revisions on the fly
praveenkuttappan Oct 15, 2024
12b20bb
return upgraded results
praveenkuttappan Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/dotnet/APIView/APIViewWeb/Managers/APIRevisionsManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,13 @@ public APIRevisionsManager(
/// <returns></returns>
public async Task<PagedList<APIRevisionListItemModel>> GetAPIRevisionsAsync(ClaimsPrincipal user, PageParams pageParams, APIRevisionsFilterAndSortParams filterAndSortParams)
{
return await _apiRevisionsRepository.GetAPIRevisionsAsync(user, pageParams, filterAndSortParams);
var revisions = await _apiRevisionsRepository.GetAPIRevisionsAsync(user, pageParams, filterAndSortParams);
List<APIRevisionListItemModel> upgradedList = [];
foreach (var item in revisions)
{
upgradedList.Add(await UpgradeAPIRevisionIfRequired(item));
}
return revisions;
}

/// <summary>
Expand All @@ -85,6 +91,12 @@ public async Task<PagedList<APIRevisionListItemModel>> GetAPIRevisionsAsync(Clai
public async Task<IEnumerable<APIRevisionListItemModel>> GetAPIRevisionsAsync(string reviewId, string packageVersion = "", APIRevisionType apiRevisionType = APIRevisionType.All)
{
var apiRevisions = await _apiRevisionsRepository.GetAPIRevisionsAsync(reviewId);
List<APIRevisionListItemModel> upgradedList = [];
foreach (var item in apiRevisions)
{
upgradedList.Add(await UpgradeAPIRevisionIfRequired(item));
}
apiRevisions = upgradedList;

if (apiRevisionType != APIRevisionType.All)
apiRevisions = apiRevisions.Where(r => r.APIRevisionType == apiRevisionType);
Expand Down