Skip to content

Conversation

@scbedd
Copy link
Member

@scbedd scbedd commented Oct 7, 2024

FYI @JimSuplizio

This is what a result looks like:

{
  "Name": "spring-cloud-azure-starter-monitor",
  "Version": "1.0.0-beta.7",
  "DevVersion": null,
  "DirectoryPath": "sdk/spring/spring-cloud-azure-starter-monitor",
  "ServiceDirectory": "spring",
  "ReadMePath": "sdk/spring/spring-cloud-azure-starter-monitor/README.md",
  "ChangeLogPath": "sdk/spring/spring-cloud-azure-starter-monitor/CHANGELOG.md",
  "Group": "com.azure.spring",
  "SdkType": "spring",
  "IsNewSdk": true,
  "ArtifactName": "spring-cloud-azure-starter-monitor",
  "ReleaseStatus": "Unreleased",
  "IncludedForValidation": false,
  "AdditionalValidationPackages": null,
  // pulled directly from ci.*.yml
  "ArtifactDetails": {
    "name": "spring-cloud-azure-starter-monitor",
    "groupId": "com.azure.spring",
    "safeName": "springcloudazurestartermonitor",
    "skipPublishDocGithubIo": true,
    "skipPublishDocMs": true,
    "skipUpdatePackageJson": true,
    "skipVerifyChangelog": true,
    "releaseInBatch": true
  }
}

Which includes pulling from a ci.blah.yml

Confirmed unbroken package-properties on:

  • android (new unrelated failure in main though)
  • ios (no package-properties usage)
  • go (no artifacts to save to the packageinfo.json, but no crash either)
  • net
  • python
  • java
  • js
  • c (doesn't use Package-Properties)
  • cpp

@scbedd scbedd self-assigned this Oct 8, 2024
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@scbedd scbedd marked this pull request as ready for review October 10, 2024 01:44
@scbedd scbedd requested a review from a team as a code owner October 10, 2024 01:44
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

Copy link
Contributor

@JimSuplizio JimSuplizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this. The only concern I have is one that we'd talked about and that's not all languages have artifacts in their yml files. For example, neither Go nor C has them and I'm not currently sure what Rust is doing but they don't seem to have individual ci.yml files in sdk/ subdirectories yet...just something to be aware of.

@scbedd
Copy link
Member Author

scbedd commented Oct 10, 2024

I'm approving this. The only concern I have is one that we'd talked about and that's not all languages have artifacts in their yml files. For example, neither Go nor C has them and I'm not currently sure what Rust is doing but they don't seem to have individual ci.yml files in sdk/ subdirectories yet...just something to be aware of.

I will ensure that it works across all the repos before merging any of them 👍

@scbedd scbedd merged commit 6852ce7 into main Oct 11, 2024
13 checks passed
@scbedd scbedd deleted the feature/enable-ci-artifact-package-property branch October 11, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants