Pylint Exception logging #9077
Merged
Pylint Exception logging #9077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge azure-sdk-tools main into main
Update working-main
More testing still to come
Also added more test cases
Also added one test and link for python implementation
Edits to fix false positives from testing against SDKs. Added more unit tests
Fix another false positive from the SDKs
Added corresponding test
Fixed another false positive
l0lawrence
reviewed
Oct 1, 2024
tools/pylint-extensions/azure-pylint-guidelines-checker/pylint_guidelines_checker.py
Show resolved
Hide resolved
tools/pylint-extensions/azure-pylint-guidelines-checker/pylint_guidelines_checker.py
Outdated
Show resolved
Hide resolved
.../pylint-extensions/azure-pylint-guidelines-checker/tests/test_files/do_not_log_exceptions.py
Show resolved
Hide resolved
…on_verify Do not hardcode boolean connection verify
Invalid use of @overload
Merge main into exception-logging
Address merge conflicts and finalize merge.
Switch "." and "name" to ".__name__"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #3227