Skip to content

Conversation

@praveenkuttappan
Copy link
Member

Fixes following issue in attribute line

Attribute line is shown as [AttributeUsage(AttributeTargets . Class ) ] instead of [AttributeUsage(AttributeTargets.Class )]

@praveenkuttappan praveenkuttappan added APIView Issues related to APIView core functionality or UI Central-EngSys This issue is owned by the Engineering System team. labels Aug 27, 2024
@praveenkuttappan praveenkuttappan self-assigned this Aug 27, 2024
attributeLine.AddToken(ReviewToken.CreatePunctuationToken(SyntaxKind.EqualsToken));
BuildTypedConstant(attributeLine, argument.Value);
}
attributeLine.Tokens.Last().HasSuffixSpace = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christothes are there any other cases where there needs to be special considerations for attributes?

@praveenkuttappan
Copy link
Member Author

Review block for attribute with class looks like below with this fix.

[AttributeUsage(AttributeTargets.Class)] 
public sealed class PersistableModelProxyAttribute : Attribute { 
  public PersistableModelProxyAttribute(Type proxyType); 
  [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicConstructors | DynamicallyAccessedMemberTypes.NonPublicConstructors)] 
  public Type ProxyType { get; }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

APIView Issues related to APIView core functionality or UI Central-EngSys This issue is owned by the Engineering System team.

Projects

Status: ✅ Done
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants