Allow save-package-properties to exit 0 #8879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scbedd
approved these changes
Aug 23, 2024
Member
scbedd
left a comment
scbedd
left a comment
There was a problem hiding this comment.
I especially like the fact that the old style "service directory oriented" will still fail if detects no package. Which IS reasonable. This seems g2g to me.
Collaborator
|
The following pipelines have been queued for testing: |
This was referenced Aug 23, 2024
azure-sdk
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Aug 24, 2024
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#8879 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Patrick Hallisey <[email protected]>
Member
Author
|
/check-enforcer override ADO check suite not updating. Completed successfully |
weshaggard
reviewed
Aug 26, 2024
| $outputPath = Join-Path -Path $outDirectory "$configFilePrefix.json" | ||
| Write-Host "Output path of json file: $outputPath" | ||
| $outDir = Split-Path $outputPath -parent | ||
| if (-not (Test-Path -path $outDir)) |
Member
There was a problem hiding this comment.
Is there any case where this directory doesn't already exist?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow save-package-properties to exit 0 when PRs produce no package changes