Apiview token changes #8851
Merged
Apiview token changes #8851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveenkuttappan
requested review from
chidozieononiwu and
christothes
as code owners
praveenkuttappan
added
APIView
praveenkuttappan
force-pushed
the
apiview_token_changes
branch
from
015624e to
9d4ccc1
Compare
maririos
approved these changes
Aug 19, 2024
Member
maririos
left a comment
maririos
left a comment
There was a problem hiding this comment.
nothing jumped out for me. but we'll need a review from @chidozieononiwu
chidozieononiwu
approved these changes
Aug 19, 2024
praveenkuttappan
force-pushed
the
apiview_token_changes
branch
from
31a0806 to
1754ed6
Compare
maririos
reviewed
Aug 22, 2024
src/dotnet/APIView/ClientSPA/src/app/_workers/apitree-builder.worker.spec.ts
Show resolved
Hide resolved
maririos
reviewed
Aug 22, 2024
maririos
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has client and server side changes to process new token schema and render them. .NET parser and token models changes from PR #8816 are also included in this PR to support building the project since those changes are not yet merged.