Skip to content

Improve Logging #8795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 13, 2024
Merged

Improve Logging #8795

merged 11 commits into from
Aug 13, 2024

Conversation

@wanlwanl
Copy link
Contributor

@wanlwanl wanlwanl commented Aug 7, 2024 •
edited
Loading

Improvements

  1. Hide useless logs for npm pack
  2. Make log prefix consistent
  3. Add error summary and details when command failed

Related Issues

Next Steps

  • Add TSG (looks like we don't have suitable TSG)

@wanlwanl
Improve Logging
dda5794 
1. Hide useless logs for npm pack
2. Make log prefix consistent
3. Add error summary and details when command failed
@wanlwanl wanlwanl marked this pull request as ready for review August 7, 2024 07:44
raych1
raych1 reviewed Aug 7, 2024
View reviewed changes
raych1
raych1 reviewed Aug 7, 2024
View reviewed changes
raych1
raych1 reviewed Aug 7, 2024
View reviewed changes
@raych1
Copy link
Member

raych1 commented Aug 7, 2024

@wanlwanl
In general, please add the next steps from user perspective to the error messages.

@wanlwanl
Copy link
Contributor Author

wanlwanl commented Aug 9, 2024

@wanlwanl In general, please add the next steps from user perspective to the error messages.
@raych1
Added in most outer error log

wanlwanl
wanlwanl commented Aug 9, 2024
View reviewed changes
raych1
raych1 reviewed Aug 9, 2024
View reviewed changes
raych1
raych1 reviewed Aug 9, 2024
View reviewed changes
raych1
raych1 reviewed Aug 9, 2024
View reviewed changes
raych1
raych1 reviewed Aug 9, 2024
View reviewed changes
raych1
raych1 reviewed Aug 9, 2024
View reviewed changes
raych1
raych1 reviewed Aug 9, 2024
View reviewed changes
raych1
raych1 reviewed Aug 9, 2024
View reviewed changes
raych1
raych1 reviewed Aug 9, 2024
View reviewed changes
@wanlwanl wanlwanl enabled auto-merge (squash) August 13, 2024 08:02
@wanlwanl wanlwanl merged commit 08698d3 into Azure:main Aug 13, 2024
@wanlwanl
Copy link
Contributor Author

wanlwanl commented Aug 13, 2024

@raych1 I merged it otherwise there will be many conflicts. please comment if you have concerns

@maorleger maorleger mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raych1 raych1 raych1 left review comments

@qiaozha qiaozha qiaozha approved these changes

@MaryGao MaryGao Awaiting requested review from MaryGao MaryGao is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wanlwanl @raych1 @qiaozha