Skip to content

[test-proxy] Only remove session once body has been written #8709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 30, 2024
Merged

[test-proxy] Only remove session once body has been written #8709

merged 10 commits into from
Jul 30, 2024

Conversation

@mikeharder
Copy link
Member

@mikeharder mikeharder commented Jul 26, 2024 •
edited by scbedd
Loading

  • Minimizes window of race condition, where client retries after test-proxy has already removed session
  • Prevents needless locks in HandlePlaybackRequest

@mikeharder mikeharder marked this pull request as ready for review July 26, 2024 05:39
@mikeharder mikeharder requested review from benbp and scbedd as code owners July 26, 2024 05:39
@mikeharder mikeharder self-assigned this Jul 26, 2024
mikeharder
mikeharder commented Jul 26, 2024
View reviewed changes
@scbedd scbedd self-assigned this Jul 30, 2024
@scbedd scbedd merged commit f3e3a51 into main Jul 30, 2024
@scbedd scbedd deleted the test-proxy-client-retry branch July 30, 2024 18:03
This was referenced Jul 30, 2024
Closed
Merged
@maorleger maorleger mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benbp benbp benbp approved these changes

@scbedd scbedd Awaiting requested review from scbedd scbedd is a code owner

Assignees

@mikeharder mikeharder

@scbedd scbedd

Labels

None yet

Projects

Azure SDK EngSys 🍔🌭
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mikeharder @benbp @scbedd