-
Notifications
You must be signed in to change notification settings - Fork 227
Update PR Tagging For Release Failures #868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
praveenkuttappan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
|
@chidozieononiwu you can use this PR as a case study for what happens if the tools PR gets merged while the language Sync PR's are still open. You can see that newer sync PRs like https://github.com/Azure/azure-sdk-for-net/pull/14518/files have all the changes that are in tools master. |
It doesn't seem that this would cause much grief. The bigger problem is when some Sync PRs are merged but the Tools PR is still opened. So new sync PRs end up replacing previously merged changes. |
|
It ends up mixing multiple tools PRs together which might cause some issues, if nothing else it will cause pollution in the other PRs. At any rate we should get those other sync PR's merged. |
My understanding after reading the github API docs was that the assignees setting was replaced by a push. It's actually additive, forgiving of duplicates. Adjust to push 1 at a time, turning the step yellow when any fail to add.