Skip to content

Conversation

@scbedd
Copy link
Member

@scbedd scbedd commented Aug 13, 2020

  • Additional Error Handling on Resolving an Identity
  • Rework how users are added to a PR
  • Allow Failed Tagging of a User on PR

My understanding after reading the github API docs was that the assignees setting was replaced by a push. It's actually additive, forgiving of duplicates. Adjust to push 1 at a time, turning the step yellow when any fail to add.

@scbedd scbedd requested a review from a team as a code owner August 13, 2020 02:00
@scbedd scbedd changed the title Update PR Tagging Update PR Tagging For Release Failures Aug 13, 2020
Copy link
Member

@praveenkuttappan praveenkuttappan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

azure-sdk added a commit to azure-sdk/azure-sdk-for-android that referenced this pull request Aug 24, 2020
azure-sdk added a commit to azure-sdk/azure-sdk-for-cpp that referenced this pull request Aug 24, 2020
azure-sdk added a commit to azure-sdk/azure-sdk-for-ios that referenced this pull request Aug 24, 2020
azure-sdk added a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Aug 24, 2020
azure-sdk added a commit to azure-sdk/azure-sdk-for-net that referenced this pull request Aug 24, 2020
@weshaggard
Copy link
Member

@chidozieononiwu you can use this PR as a case study for what happens if the tools PR gets merged while the language Sync PR's are still open. You can see that newer sync PRs like https://github.com/Azure/azure-sdk-for-net/pull/14518/files have all the changes that are in tools master.

@chidozieononiwu
Copy link
Member

@chidozieononiwu you can use this PR as a case study for what happens if the tools PR gets merged while the language Sync PR's are still open. You can see that newer sync PRs like https://github.com/Azure/azure-sdk-for-net/pull/14518/files have all the changes that are in tools master.

It doesn't seem that this would cause much grief. The bigger problem is when some Sync PRs are merged but the Tools PR is still opened. So new sync PRs end up replacing previously merged changes.

@weshaggard
Copy link
Member

It ends up mixing multiple tools PRs together which might cause some issues, if nothing else it will cause pollution in the other PRs. At any rate we should get those other sync PR's merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants