Skip to content

Disable Review Approval Button for non-prefered approvers #8640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Disable Review Approval Button for non-prefered approvers #8640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ...View/ClientSPA/src/app/_components/review-page-options/review-page-options.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,7 @@
</ng-template>
</li>
<li class="list-group-item text-center">
<ng-container *ngIf="reviewIsApproved; else reviewIsNotApprovedBlock">
<span class="small text-muted mt-1">
Approved for First Release By: <a href="{{webAppUrl}}Assemblies/Profile/{{reviewApprover}}">{{reviewApprover}}</a>
</span>
</ng-container>
<ng-template #reviewIsNotApprovedBlock>
<ng-container *ngIf="!reviewIsApproved && preferredApprovers.includes(userProfile?.userName!); else reviewApprovalHidden">
<span class="small text-muted">Approves First Release of the package</span>
<div class="d-grid gap-2">
<button class="btn btn-success" type="button"
Expand All @@ -43,6 +38,11 @@
</button>
</div>
<span class="small mt-2 text-muted">First Release Approval Pending</span>
</ng-container>
<ng-template #reviewApprovalHidden>
<span class="small text-muted mt-1">
Approved for First Release By: <a href="{{webAppUrl}}Assemblies/Profile/{{reviewApprover}}">{{reviewApprover}}</a>
</span>
</ng-template>
</li>
</ul>
Expand Down