Skip to content

Refactor PipelineWitness #8623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2024
Merged

Refactor PipelineWitness #8623

merged 1 commit into from
Jul 16, 2024

Conversation

@hallipr
Copy link
Member

@hallipr hallipr commented Jul 13, 2024 •
edited
Loading

  • Make class names and namespace separation more consistent between AzurePipeline and GitHubActions
  • Use GeneratedRegex attribute for all regex
  • Prepare for addition of missing blob workers
    • Move common logic for distributed, peroidic background services to new abstract class
    • Nest config settings for background workers

@hallipr
Copy link
Member Author

hallipr commented Jul 13, 2024 •
edited
Loading

This is to reduce the amount of refactoring in #8424 - Add support for missing build processing

@hallipr hallipr force-pushed the users/pahallis/refactor branch 2 times, most recently from 84e5906 to 7c40d2a Compare July 13, 2024 05:09
@hallipr
Refactor PipelineWitness
00cad52 
- Make class names and namespace separation more consistent between AzurePipeline and GitHubActions
- Use GeneratedRegex attribute for all regex
- Prepare for missing blob workers
  - Move common logic for distributed, peroidic background services to new abstract class
  - Nest config settings for background workers
@hallipr hallipr force-pushed the users/pahallis/refactor branch from 7c40d2a to 00cad52 Compare July 13, 2024 05:09
@hallipr
Copy link
Member Author

hallipr commented Jul 16, 2024

/check-enforcer override

@hallipr hallipr enabled auto-merge (squash) July 16, 2024 17:45
@hallipr hallipr merged commit b03d16d into main Jul 16, 2024
@hallipr hallipr deleted the users/pahallis/refactor branch July 16, 2024 17:46
@maorleger maorleger mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weshaggard weshaggard weshaggard approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hallipr @weshaggard