Skip to content

[tsp-client] Fix tsp compile diagnostics logging #8529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 2, 2024
Merged

[tsp-client] Fix tsp compile diagnostics logging #8529

merged 7 commits into from
Jul 2, 2024

Conversation

@catalinaperalta
Copy link
Member

@catalinaperalta catalinaperalta commented Jul 1, 2024 •
edited
Loading

Use logger for diagnostics and exit if there are diagnostics reported during the tsp compile call

Fixes #8523

@catalinaperalta catalinaperalta marked this pull request as ready for review July 1, 2024 23:24
timotheeguerin
timotheeguerin reviewed Jul 1, 2024
View reviewed changes
@catalinaperalta catalinaperalta merged commit 3e90e19 into main Jul 2, 2024
@catalinaperalta catalinaperalta deleted the fix-tsp-compile branch July 2, 2024 22:06
@maorleger maorleger mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timotheeguerin timotheeguerin timotheeguerin approved these changes

@joheredi joheredi Awaiting requested review from joheredi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[tsp-client] The output of the tsp compile command should be logged using the Logger

4 participants

@catalinaperalta @timotheeguerin @cperaltah