Skip to content

Fix case where changelog wasn't marked as invalid #8463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2024
Merged

Fix case where changelog wasn't marked as invalid #8463

merged 1 commit into from
Jun 18, 2024

Conversation

@weshaggard
Copy link
Member

@weshaggard weshaggard commented Jun 17, 2024

Fixing case were we didn't correctly fail the build see example https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3875412&view=logs&j=f8db92a5-5aa2-5af0-abb0-b907727011d6&t=69c0dc6a-7dc9-5030-86c4-e7a70f356a18

[debug]Verifying as a release build because ForRelease parameter is set to true
##[error]The changelog entry did not contain any of the recommended sections (Features Added, Breaking Changes, Bugs Fixed, Other Changes), please add at least one. See https://aka.ms/azsdk/guideline/changelogs for more info.

Finishing: Verify ChangeLogEntry for azure-ai-translation-document

@weshaggard weshaggard requested a review from a team as a code owner June 17, 2024 22:28
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jun 17, 2024

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Jun 18, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Jun 18, 2024
@azure-sdk @weshaggard
Sync eng/common directory with azure-sdk-tools for PR 8463 (#30091)
b1a0bcb 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#8463 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Wes Haggard <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>
@weshaggard weshaggard merged commit 4cd1587 into Azure:main Jun 18, 2024
@weshaggard weshaggard deleted the FixChangeLogCheck branch June 18, 2024 22:39
@xirzec xirzec mentioned this pull request Jun 24, 2024
Closed
@maorleger maorleger mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@praveenkuttappan praveenkuttappan Awaiting requested review from praveenkuttappan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@weshaggard @azure-sdk