Skip to content

Plumb env vars through deploy test resources #8377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 6, 2024
Merged

Plumb env vars through deploy test resources #8377

merged 3 commits into from
Jun 6, 2024

Conversation

@benbp
Copy link
Member

@benbp benbp commented Jun 4, 2024 •
edited
Loading

This will allow us to pass OIDC token env and possibly other values through to deploy pre/post scripts.

@benbp benbp requested a review from a team as a code owner June 4, 2024 23:07
@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Jun 4, 2024
@benbp benbp self-assigned this Jun 4, 2024
@benbp benbp requested a review from weshaggard June 4, 2024 23:07
@benbp benbp mentioned this pull request Jun 4, 2024
Merged
weshaggard
weshaggard reviewed Jun 4, 2024
View reviewed changes
@benbp benbp force-pushed the benbp/deploy-env-vars branch from 2c00dd8 to f67ab66 Compare June 4, 2024 23:12
@benbp benbp force-pushed the benbp/deploy-env-vars branch from f67ab66 to eda750c Compare June 4, 2024 23:24
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jun 4, 2024

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Jun 4, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
danieljurek
danieljurek reviewed Jun 5, 2024
View reviewed changes
danieljurek
danieljurek reviewed Jun 5, 2024
View reviewed changes
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jun 5, 2024

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jun 5, 2024

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp benbp enabled auto-merge (squash) June 5, 2024 22:52
@benbp benbp mentioned this pull request Jun 6, 2024
Closed
azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Jun 6, 2024
@azure-sdk @benbp @danieljurek
Sync eng/common directory with azure-sdk-tools for PR 8377 (#29906)
d34de02 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#8377 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Ben Broderick Phillips <[email protected]>
Co-authored-by: Daniel Jurek <[email protected]>
@benbp benbp merged commit 1c2d763 into Azure:main Jun 6, 2024
@benbp benbp deleted the benbp/deploy-env-vars branch June 6, 2024 23:19
JimSuplizio pushed a commit to JimSuplizio/azure-sdk-tools that referenced this pull request Jun 7, 2024
@benbp @danieljurek @JimSuplizio
Plumb env vars through deploy test resources (Azure#8377)
d9cf292 
* Plumb env vars through deploy test resources

* Update eng/common/TestResources/deploy-test-resources.yml

Co-authored-by: Daniel Jurek <[email protected]>

* Update eng/common/TestResources/deploy-test-resources.yml

Co-authored-by: Daniel Jurek <[email protected]>

---------

Co-authored-by: Daniel Jurek <[email protected]>
@maorleger maorleger mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danieljurek danieljurek danieljurek approved these changes

@weshaggard weshaggard weshaggard approved these changes

Assignees

@benbp benbp

Labels

Central-EngSys This issue is owned by the Engineering System team.

Projects

Azure SDK EngSys 🍔🌭
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@benbp @azure-sdk @danieljurek @weshaggard