Skip to content

Remove SAS from comments and option help #8328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2024
Merged

Remove SAS from comments and option help #8328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tools/github-team-user-store/GitHubTeamUserStore/GitHubTeamUserStore/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,19 +11,19 @@ static async Task Main(string[] args)
{
var teamUserBlobStorageUriOption = new Option<string>
(name: "--teamUserBlobStorageURI",
description: "The team/user blob storage URI including the SAS.");
description: "The team/user blob storage URI.");
teamUserBlobStorageUriOption.AddAlias("-tUri");
teamUserBlobStorageUriOption.IsRequired = true;

var userOrgVisibilityBlobStorageUriOption = new Option<string>
(name: "--userOrgVisibilityBlobStorageURI",
description: "The user/org blob storage URI including the SAS.");
description: "The user/org blob storage URI.");
userOrgVisibilityBlobStorageUriOption.AddAlias("-uUri");
userOrgVisibilityBlobStorageUriOption.IsRequired = true;

var repoLabelBlobStorageUriOption = new Option<string>
(name: "--repoLabelBlobStorageURI",
description: "The repo/label blob storage URI including the SAS.");
description: "The repo/label blob storage URI.");
repoLabelBlobStorageUriOption.AddAlias("-rUri");
repoLabelBlobStorageUriOption.IsRequired = true;

Expand Down
6 changes: 3 additions & 3 deletions tools/github-team-user-store/GitHubTeamUserStore/GitHubTeamUserStore/TeamUserGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ public class TeamUserGenerator
/// teams is less than 1/10th of that. The team/user data is serialized into json and stored in azure blob storage.
/// </summary>
/// <param name="gitHubEventClient">Authenticated GitHubEventClient</param>
/// <param name="teamUserBlobStorageUri">The URI, including SAS, of the team/user blob storage URI</param>
/// <param name="userOrgVisibilityBlobStorageUri">The URI, including SAS, of the user/org visibility blob</param>
/// <param name="teamUserBlobStorageUri">The URI of the team/user blob storage URI</param>
/// <param name="userOrgVisibilityBlobStorageUri">The URI of the user/org visibility blob</param>
/// <returns>true if everything stored successfully, false otherwise</returns>
public static async Task<bool> GenerateAndStoreTeamUserAndOrgData(GitHubEventClient gitHubEventClient,
string teamUserBlobStorageUri,
Expand Down Expand Up @@ -160,7 +160,7 @@ private static async Task<bool> VerifyStoredTeamUsers(GitHubEventClient gitHubEv
/// to generate the org visibility data.
/// </summary>
/// <param name="gitHubEventClient">Authenticated GitHubEventClient</param>
/// <param name="userOrgVisibilityBlobStorageUri">The URI, including SAS, of the user/org visibility blob</param>
/// <param name="userOrgVisibilityBlobStorageUri">The URI of the user/org visibility blob</param>
/// <returns></returns>
public static async Task<bool> GenerateAndStoreUserOrgData(GitHubEventClient gitHubEventClient,
string userOrgVisibilityBlobStorageUri,
Expand Down