Skip to content

Conversation

@scbedd
Copy link
Member

@scbedd scbedd commented May 16, 2024

Brought to my attention by @chlowell

@scbedd scbedd requested review from benbp and mikeharder as code owners May 16, 2024 23:21
@scbedd scbedd self-assigned this May 16, 2024
Copy link
Member

@benbp benbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Wonder if a hashset would be useful here.

@scbedd
Copy link
Member Author

scbedd commented May 17, 2024

<I somehow edited your comment instead of responding? somehow?>

Hashsets don't maintain order, which we enforce for simplicity of debugging sanitizers by the users.

I see what you're asking now. I could do it that way, yea. Just...didn't. The hashset value probably wouldn't collide in a way that is useful anyway, as we'd use the ID of the sanitizer as the key, not the regex of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants