Skip to content

Feedback from Java Integration #8272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 15, 2024
Merged

Feedback from Java Integration #8272

merged 6 commits into from
May 15, 2024

Conversation

@scbedd
Copy link
Member

@scbedd scbedd commented May 15, 2024 •
edited
Loading

  • Eliminating any possibility that a set of session sanitizers is always stable for a new playback/recording session
  • Handling JToken parsing errors in the BodyKeySanitizer with logging to repro the issue and fix the sanitizer itself later.
  • Fix failing CLI integration test
  • Remove duplicate common sanitizer

@scbedd scbedd requested review from benbp and mikeharder as code owners May 15, 2024 17:54
@scbedd scbedd changed the title Lock Session Sanitizers on Session Start Feedback from Java Integration May 15, 2024
@scbedd scbedd self-assigned this May 15, 2024
@scbedd scbedd merged commit 34521cc into main May 15, 2024
@scbedd scbedd deleted the lock-on-session-start branch May 15, 2024 20:45
@scbedd scbedd mentioned this pull request May 17, 2024
Merged
@maorleger maorleger mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benbp benbp benbp approved these changes

@mikeharder mikeharder Awaiting requested review from mikeharder mikeharder is a code owner

Assignees

@scbedd scbedd

Labels

None yet

Projects

Azure SDK EngSys 🍔🌭
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scbedd @benbp