Add base branch baseline file for additional PR filtering #8264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimSuplizio
added
the
CODEOWNERS Linter
weshaggard
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per instructions:
The codeowners-linter pipeline, for PRs, suffers from the problem that if the base branch has errors the PR will effectively be stuck until those errors are fixed and the updated CODEOWNERS file is merged into the PR branch. This happens when people leave the company or Azure. The plan is to create a base branch baseline file from the base branch CODEOWNERS and use that to further filter any errors in the PR. This way, only errors in the PR will prevent the PR check in.
This fix comes in two parts and this is the first. The linter has a new option, -bbl, which takes a path, including the filename, to the base branch baseline file. If generating the baseline, with the -gbl option, it'll create the file. If filtering errors, with the -fbl option, it'll use the base branch baseline file to further filter errors. The -bbl option, if not passed in or empty, in the case scheduled runs, just behaves as it previously did.