SAS token removal from team/user store #8246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weshaggard
approved these changes
May 10, 2024
Member
weshaggard
left a comment
weshaggard
left a comment
There was a problem hiding this comment.
Just remember to undo your commented out stuff.
Contributor
Author
|
I need to override check-enforcer. The reason is GitHubTeamUserStore can't automatically kick off a pipeline in PRs due to the number of GitHub API calls required to get the data (2000) and the fact that there's a 5000/hour limit in the PAT. |
Contributor
Author
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use azure credentials instead of the SAS token for the team/user store.
In the pipeline use the AzureCLI task to authenticate to the Azure SDK Artifacts, which has already been setup. As mentioned in the comments, we can't use the DefaultAzureCredential. The reason for this is because, in CI pipelines, it picks up the ManagedIdentityCredential over the AzureCliCredential and the AzureCliCredential is what we need to be using.