Skip to content

Conversation

@scbedd
Copy link
Member

@scbedd scbedd commented Apr 18, 2024

TODO:

  • Sanitizers now have an id
  • Existing behavior of the proxy WRT registering a sanitizer for a session/recording is maintained, but now sanitizers are stored in a central location
  • Investigate 2 failing unit tests from JS integration test run, resolve.
    • Getting some assistance from @HarshaNalluru on this failure, thank you Harsha!
    • 2ece462 resolved issues. Glad the tests caught it thanks again Harsha!
  • POST Admin/AddSanitizer now returns a body containing the newly added sanitizerId
  • GET Admin/Sanitizers is a new route that returns either the session sanitizers (with ids) or specific recordingId based on the presence of x-recording-id header
  • POST Admin/RemoveSanitizer
  • and POST Admin/RemoveSanitizers should remove the given sanitizer Ids from the active session or recording
    • Arguably I should use DELETE here, but some clients run into problems sending along a body with a DELETE request, so I'm just going to keep this POST and keep it dumb simple.
  • Tests for RemoveSanitizer

@scbedd scbedd self-assigned this Apr 18, 2024
@scbedd
Copy link
Member Author

scbedd commented Apr 18, 2024

/azp run tools - test-proxy - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scbedd
Copy link
Member Author

scbedd commented Apr 18, 2024

/azp run tools - test-proxy - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scbedd
Copy link
Member Author

scbedd commented Apr 19, 2024

/azp run tools - test-proxy - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scbedd scbedd marked this pull request as ready for review April 22, 2024 19:21
@scbedd scbedd requested a review from mikeharder as a code owner April 22, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants