Skip to content

Add polly retry to get artifact URL from DevOps #8112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 17, 2024
Merged

Add polly retry to get artifact URL from DevOps #8112

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c22f922
Add polly retry to get artifact URL from DevOps
praveenkuttappan Apr 17, 2024
abd6b96
Add polly retry to get artifact URL from DevOps
praveenkuttappan Apr 17, 2024
5fe73dc
Update URL response handling
praveenkuttappan Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions src/dotnet/APIView/APIViewWeb/Repositories/DevopsArtifactRepository.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,25 @@ public async Task<Stream> DownloadPackageArtifact(string repoName, string buildI

private async Task<string> getDownloadArtifactUrl(string buildId, string artifactName, string project)
{
var pauseBetweenFailures = TimeSpan.FromSeconds(2);
Copy link
Member

@maririos maririos Apr 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this number arbritary? or it has history to it

Copy link
Member Author

@praveenkuttappan praveenkuttappan Apr 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 seconds should be ideally enough to start the delay span. So, it's just arbitrary.

var retryPolicy = Policy
.Handle<HttpRequestException>()
.WaitAndRetryAsync(5, i => pauseBetweenFailures);

var connection = await CreateVssConnection();
var buildClient = connection.GetClient<BuildHttpClient>();
var artifact = await buildClient.GetArtifactAsync(project, int.Parse(buildId), artifactName);
return artifact?.Resource?.DownloadUrl;
string url = null;
await retryPolicy.ExecuteAsync(async () =>
{
var artifact = await buildClient.GetArtifactAsync(project, int.Parse(buildId), artifactName);
url = artifact?.Resource?.DownloadUrl;
});

if (string.IsNullOrEmpty(url))
{
throw new Exception(string.Format("Failed to get download url for artifact {0} in build {1} in project {2}", artifactName, buildId, project));
}
return url;
}

private async Task<VssConnection> CreateVssConnection()
Expand Down