Use subset of Go module identity for package name #7868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The build for APIViewWeb is broken, can somebody please take a look? |
Member
|
@chidozieononiwu could please take a look? |
chlowell
approved these changes
Mar 13, 2024
Member
|
This has been resolved. Could you do a rebase with main. |
This will prevent collisions as the subset is guaranteed to be unique. Updated dependencies.
jhendrixMSFT
force-pushed
the
apiview-packagename
branch
from
ea63446 to
57724d5
Compare
RickWinter
approved these changes
Mar 26, 2024
praveenkuttappan
requested changes
Mar 29, 2024
Member
praveenkuttappan
left a comment
praveenkuttappan
left a comment
There was a problem hiding this comment.
Package name must include sdk/ as prefix to match the package name expected in all other tooling for Go.
praveenkuttappan
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will prevent collisions as the subset is guaranteed to be unique. Updated dependencies.