Update package version on automatic API revision #7819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveenkuttappan
added
APIView
chidozieononiwu
approved these changes
Mar 5, 2024
maririos
reviewed
Mar 6, 2024
Member
Author
|
@chidozieononiwu @maririos I have pushed additional changes to update label and also to add a new package version param to send actual package version instead of daily build alpha version from CI. I have fixed another issue in copying approval status to automatic review. |
maririos
reviewed
Mar 6, 2024
|
|
||
| [HttpPost] | ||
| public async Task<ActionResult> UploadAutoReview([FromForm] IFormFile file, string label, bool compareAllRevisions = false) | ||
| public async Task<ActionResult> UploadAutoReview([FromForm] IFormFile file, string label, bool compareAllRevisions = false, string packageVersion = null) |
Member
There was a problem hiding this comment.
would it be helpful to document in which cases the function expects packageVersion not to be null?
Member
Author
There was a problem hiding this comment.
I added it as null for now until all individual caller from language repo starts to send it. Once change is merged to individual repos, I will change this as required param.
maririos
approved these changes
Mar 6, 2024
This was referenced Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update package version on API revision even if API surface matches to reflect correct package version info. This change along with tagging a revision after package release will ensure that package version is updated correctly(A separate change from updating package version).