Skip to content

Conversation

@raych1
Copy link
Member

@raych1 raych1 commented Jan 23, 2024

There are two cases for the naming of JS package folder:

  • RLC package case, removing the "azure-rest-" from package name then plus "-rest" to the end of the name.
  • Non-RLC package case, removing the "azure-" from the package name.

The changes include:

  • correct the name of package folder for JS case.
  • correct the name prefix of JS ARM package.
  • add exception catch handler
  • style format fix

The pipeline test run of JS template package release with same script change looks good.

@raych1 raych1 requested a review from qiaozha January 23, 2024 10:55
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's switch to using the package info properties instead of duplicating logic.

@raych1
Copy link
Member Author

raych1 commented Jan 24, 2024

Let's switch to using the package info properties instead of duplicating logic.

@weshaggard , switched to rely on the package info. This is the test run result.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Jan 25, 2024
@raych1 raych1 merged commit 06cb15a into main Jan 25, 2024
@raych1 raych1 deleted the user/raych1/fix-js-package-folder-name branch January 25, 2024 10:16
raych1 added a commit to Azure/azure-sdk-for-js that referenced this pull request Jan 25, 2024
This PR is to add back the spec location validation back to the release
pipeline.
Here is the original PR which was reverted by an issue of the JS package
path.
#28303

Here is the PR of the fix of common script that has been merged:
Azure/azure-sdk-tools#7569

This is the [test run
result](https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3433518&view=logs&j=7bb69cc7-6f52-585e-8b13-5bae7c4a9fa4&t=7abbbe6b-d005-5c95-feb6-99ffe4e699e1)
in JS repo.

@weshaggard @jeremymeng , please review.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants