Remove CXPAttention rules constant#7092
Merged
JimSuplizio merged 1 commit intoAzure:mainfrom Oct 10, 2023
Merged
Conversation
JimSuplizio
added
the
GitHub Event Processor
weshaggard
approved these changes
Oct 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CXPAttention rule and processing was removed from github-event-processor and the event-processor.config files but the rules constant was still there. Nothing bad happens, or will happen, but the logic that detects missing rules from the config file outputs the following informational message whenever it loads a config file.
CXPAttention was not in the rules config file. Missing rules default to Off.Since the rule, itself, is gone, the rules constant needs to go away as well.