Skip to content

Fail fast on variable conflicts with subscription config#6853

Merged
benbp merged 1 commit intoAzure:mainfrom
benbp:benbp/env-var-conflict
Aug 25, 2023
Merged

Fail fast on variable conflicts with subscription config#6853
benbp merged 1 commit intoAzure:mainfrom
benbp:benbp/env-var-conflict

Conversation

@benbp
Copy link
Copy Markdown
Member

@benbp benbp commented Aug 25, 2023

We've run into this a couple times as teams migrate away from hardcoded keyvault secrets but have duplicates in the yaml, causing hard to find issues when updating values in the wrong place. The identity team, for example, has some of their core variables in our base config (which should be moved).

I'm going to update the language test pipelines to pass down EnvVars from the tests/ci.yml files just to fail fast on any conflicts.

@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Aug 25, 2023
@benbp benbp self-assigned this Aug 25, 2023
@benbp benbp requested a review from christothes August 25, 2023 16:36
@benbp benbp force-pushed the benbp/env-var-conflict branch from 8c4b73f to 9470224 Compare August 25, 2023 16:46
@azure-sdk
Copy link
Copy Markdown
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp benbp force-pushed the benbp/env-var-conflict branch from 9470224 to 2c0657d Compare August 25, 2023 18:29
@azure-sdk
Copy link
Copy Markdown
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp benbp force-pushed the benbp/env-var-conflict branch from 2c0657d to 300dd48 Compare August 25, 2023 18:42
@azure-sdk
Copy link
Copy Markdown
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Aug 25, 2023
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#6853 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
@benbp benbp merged commit a87d4c1 into Azure:main Aug 25, 2023
@benbp benbp deleted the benbp/env-var-conflict branch August 25, 2023 19:44
dgetu pushed a commit to Azure/azure-sdk-for-js that referenced this pull request Sep 6, 2023
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#6853 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team.

Projects

Development

Successfully merging this pull request may close these issues.

4 participants