Used ScheduledPurgeDate for both KV, MHSM#6739
Conversation
The previous property was calculated so didn't exist from the REST-based call. Also updated the api-version to the latest stable control plane version.
|
The following pipelines have been queued for testing: |
There was a problem hiding this comment.
Before merging this PR, I'd like to try running the cleanup pipeline using this PR.
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2991805&view=results
|
Fix prevents script from failing, but from the logs it appears we still need to do more to actually delete/purge the resources. |
The script runs on a schedule as well, so it will keep trying and when the purge date expires, they will finally get cleaned up on the next run. That's how it was designed and has been working. What's concerning is how many vaults and HSMs have purge protection enabled. It should almost never be necessary. I started a thread internally to address going forward. |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#6739 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Heath Stewart <heaths@microsoft.com>
|
@heaths: Can you merge this today to prevent the pipeline failures? |
|
I thought it was supposed to merge automatically once the final pipeline was approved. |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#6739 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Heath Stewart <heaths@microsoft.com>
3 participants
The previous property was calculated so didn't exist from the REST-based
call. Also updated the api-version to the latest stable control plane
version.